Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module name retrieval in backend.plugins.remove_duplicates(), plugin tests #5959

Merged
merged 9 commits into from
Nov 15, 2021
Merged

Fix module name retrieval in backend.plugins.remove_duplicates(), plugin tests #5959

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e3faf8
FIX: correct module name retrieval in `backend.plugins.remove_duplica…
kmuehlbauer Nov 9, 2021
d649953
remove equal entrypoints, use `entrypoint.value` to extract module name
kmuehlbauer Nov 9, 2021
4cfe4ba
FIX: switch from pkg_resources to importlib in test_plugins.py
kmuehlbauer Nov 9, 2021
bd6db79
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 9, 2021
ee89d92
Fix imports
kmuehlbauer Nov 9, 2021
823778d
WIP: remove stale code, add whats-new.rst entry
kmuehlbauer Nov 9, 2021
e132893
WIP: change imports per review discussion
kmuehlbauer Nov 10, 2021
697b112
fix mypy issue with importlib imports, see #5979
kmuehlbauer Nov 14, 2021
31f644c
Merge remote-tracking branch 'origin/main' into fix-5944
kmuehlbauer Nov 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/backends/plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ def remove_duplicates(entrypoints):
unique_entrypoints.append(matches[0])
matches_len = len(matches)
if matches_len > 1:
selected_module_name = matches[0].module_name
all_module_names = [e.module_name for e in matches]
selected_module_name = matches[0].name
all_module_names = [e.name for e in matches]
kmuehlbauer marked this conversation as resolved.
Show resolved Hide resolved
warnings.warn(
f"Found {matches_len} entrypoints for the engine name {name}:"
f"\n {all_module_names}.\n It will be used: {selected_module_name}.",
kmuehlbauer marked this conversation as resolved.
Show resolved Hide resolved
Expand Down