Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when no backend engine is found. #5300

Merged
merged 5 commits into from
May 18, 2021

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 13, 2021

Also includes a better error message when loading a tutorial dataset but an underlying IO dependency is not found.

I consider this progress towards fixing GH5291 but not a complete fix
yet.
@shoyer
Copy link
Member Author

shoyer commented May 13, 2021

@alexamici @aurghs any thoughts?

@pep8speaks
Copy link

pep8speaks commented May 13, 2021

Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-14 22:41:45 UTC

Comment on lines +39 to +45
file_formats = {
"air_temperature": 3,
"rasm": 3,
"ROMS_example": 4,
"tiny": 3,
"eraint_uvz": 3,
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also mention the backend in the list of the available datasets for open_dataset?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good idea for future work :)

@andersy005
Copy link
Member

@alexamici @aurghs any thoughts?

@alexamici @aurghs, the gentlest of bumps on this. Have a few minutes to take a look at this? 😄

@aurghs
Copy link
Collaborator

aurghs commented May 18, 2021

That's perfect.

@shoyer shoyer merged commit 24c6152 into pydata:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ds = xr.tutorial.load_dataset("air_temperature") with 0.18 needs engine argument
5 participants