Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime decoding when time units are 'days since 0000-01-01 00:00:00' #522

Closed
wants to merge 8 commits into from
Closed

Fix datetime decoding when time units are 'days since 0000-01-01 00:00:00' #522

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce24aae
added close_files option to scipy backend
rabernat Jul 11, 2015
0145d62
added additional file closing calls
rabernat Jul 11, 2015
53bfac6
Merge remote-tracking branch 'upstream/master'
rabernat Jul 11, 2015
d47e637
trying sync fork
rabernat Jul 23, 2015
74fc196
Merge branch 'master' into temp
rabernat Jul 23, 2015
1b39371
Merge branch 'master' into temp2
rabernat Jul 23, 2015
608f0d4
Merge remote-tracking branch 'upstream/master'
rabernat Aug 8, 2015
54f63df
Fixes #521
rabernat Aug 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion xray/conventions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,21 @@ def _unpack_netcdf_time_units(units):
def _decode_datetime_with_netcdf4(num_dates, units, calendar):
import netCDF4 as nc4

dates = np.asarray(nc4.num2date(num_dates, units, calendar))
try:
dates = np.asarray(nc4.num2date(num_dates, units, calendar))
except ValueError:
# num2date needs calendar year start >= 0001 C.E. (bug submitted
# to unidata about this)
since_yr_idx = units.index('since ') + 6
year = int(units[since_yr_idx:since_yr_idx+4])
assert year==0, 'this fix only works for days since year 0'
year_diff = year - 0001
new_units = units[:since_yr_idx] + '0001-01-01 00:00:00'
time = nc4.num2date(num_dates, new_units, calendar)
dates = np.asarray([datetime(d.year + year_diff, d.month, d.day,
d.hour, d.minute, d.second)
for d in time])

if (dates[np.nanargmin(num_dates)].year < 1678
or dates[np.nanargmax(num_dates)].year >= 2262):
warnings.warn('Unable to decode time axis into full '
Expand Down