Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new backend api documentation #4810
add new backend api documentation #4810
Changes from 8 commits
7e33010
75544c9
c6f64cc
11fc283
1b8ac13
e471f3a
65c339d
113197d
f9ed1d4
6b2ecd5
1958163
bba32e4
cb8d716
2adf355
7ec3238
fb03493
22794d2
67d2c1f
f58f16b
6a07a7c
1285874
112837d
bdc46aa
fe22048
f492136
fa7f212
b74c803
de9432f
c50a95c
ab62beb
e470f36
a777445
87ed0fa
1f0870e
885a6bd
1381336
0ef410a
dc36138
23e2423
99ca49e
b1eb077
39bf16b
121c060
e838d40
8633e08
3281345
992d47d
e3eb56d
a456478
abf60e0
e72ce9b
7108f80
e8499cd
0955c16
54c202c
3cc18d5
9faf5e6
06371df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I think I read somewhere that the official spelling of the package is
xarray
(I can't remember where, though). If that is still valid, I think we should make sure the documentation follows that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to the entrypoints documentation here.
EDIT: I see it's linked below. Won't hurt to add a link here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an example
YourBackendArray
in the beginning that shows the signature foropen_dataset
, the optional attributes, and the use of optionalkwargs
? It would make this document easier to understandThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be useful to add a discussion here on how a raw key is transformed to an
ExplicitIndexer
when querying an xarrayDataArray
with a third-party backend. This would be especially useful for picking good test cases for queryingDataArray
s and debugging problems in edge-cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to add something about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at what to add here. I started writing some more details, but I think It would become a little bit too long.
Today we should merge. So I suggest to merge it as it is, and I'll add later a dedicated section.