APIv2 internal cleanups #4721
Merged
APIv2 internal cleanups #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurghs
approved these changes
Dec 22, 2020
|
This cleanup involves only apiv2. I merge it. |
toddrjen
pushed a commit
to toddrjen/xarray
that referenced
this pull request
Dec 31, 2020
* Stop importing api.py in apiv2.py * Cleanup backend_kwargs / kwargs * Fix a bug in _get_mtime when filename_or_obj is a pathlib.Path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8Stop importing
api.pyinapiv2.pyand other internal cleanups.This is needed by another change that results in a cyclic import due to
api.