Remove close_on_error store.py #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexamici
approved these changes
Dec 22, 2020
alexamici
added a commit
that referenced
this pull request
Dec 22, 2020
* Add a guess_engine function to plugins. * Move most of the logic in _autodetect_engine to plugins * Add the remaining bits to autodetect logic that were not tested * Sync the APIv1 exception message with APIv2 * Apply suggestions from code review Co-authored-by: keewis <[email protected]> * Move read_magic_number logic to util.py and better error message * Add missing guess_can_open in pydap * Remove close_on_error store.py (#4719) * remove close on error for external store * remove not used import * Remove unused import (fallout from merge) Co-authored-by: keewis <[email protected]> Co-authored-by: aurghs <[email protected]>
toddrjen
pushed a commit
to toddrjen/xarray
that referenced
this pull request
Dec 31, 2020
* remove close on error for external store * remove not used import
toddrjen
pushed a commit
to toddrjen/xarray
that referenced
this pull request
Dec 31, 2020
* Add a guess_engine function to plugins. * Move most of the logic in _autodetect_engine to plugins * Add the remaining bits to autodetect logic that were not tested * Sync the APIv1 exception message with APIv2 * Apply suggestions from code review Co-authored-by: keewis <[email protected]> * Move read_magic_number logic to util.py and better error message * Add missing guess_can_open in pydap * Remove close_on_error store.py (pydata#4719) * remove close on error for external store * remove not used import * Remove unused import (fallout from merge) Co-authored-by: keewis <[email protected]> Co-authored-by: aurghs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
close_on_errorin store.py. This change involves only apiv2.Currently,
api_v2.open_datasetcan take in input a store instead of a file. In case of error, xarray closes the store.Xarray should manage the closure of a store that has been instantiated externally.
This PR correct this behaviour in apiv2
isort . && black . && mypy . && flake8