APIv2: pass user defined filename_or_obj to backends as is
#4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @alexamici! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-12-18 13:50:24 UTC |
alexamici
changed the title
filename_or_obj to beckends as is
alexamici
changed the title
filename_or_obj to beckends as isfilename_or_obj to beckends as is
alexamici
changed the title
filename_or_obj to beckends as isfilename_or_obj to beckends as is
keewis
changed the title
filename_or_obj to beckends as isfilename_or_obj to backends as is
aurghs
approved these changes
Dec 22, 2020
toddrjen
pushed a commit
to toddrjen/xarray
that referenced
this pull request
Dec 31, 2020
…4707) * Pass filename_or_obj as passed by the user to beckends * Code style * Fix autodetection to also accept pathlib.Path * ensure _get_default_engine get an str object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8whats-new.rstThe change affects only APIv2.
Pros:
open_datasetpasses the dataset description objectfilename_or_objto the backends without fiddling with it. This is more and more important as several backends know how to opendicts,file'sstrs that are not paths (rasterio for example accepts GDAL strings that are not paths and that is one of the reasonsengine="rasterio"cannot be used inopen_dataset)Cons: