-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples for interp and interpolate_na #4621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are really good, I think they make these functions so much more approachable.
To answer your Q — I think the kwargs
are done because we want to have .interp(dim=
, but also pass some kwargs to scipy. I agree it's not that python atm. Any ideas for how to resolve?
The only issue I have is that the signatures are inconsistent. Maybe we can switch to a explicitly passed |
@dcherian, this should be ready as soon as the RTD CI passes. The failing upstream-dev CI is due to trouble with installing |
@dcherian, this is ready for review and merging |
Great improvement, thank you! |
This adds examples for
interp
andinterpolate_na
(interp_like
still needs to be done). Also, is there a reason whyinterp
andinterpolate_na
acceptkwargs
differently?isort . && black . && mypy . && flake8
whats-new.rst