Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples for interp and interpolate_na #4621

Merged
merged 7 commits into from
Nov 30, 2020
Merged

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Nov 30, 2020

This adds examples for interp and interpolate_na (interp_like still needs to be done). Also, is there a reason why interp and interpolate_na accept kwargs differently?

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are really good, I think they make these functions so much more approachable.

To answer your Q — I think the kwargs are done because we want to have .interp(dim=, but also pass some kwargs to scipy. I agree it's not that python atm. Any ideas for how to resolve?

@keewis keewis mentioned this pull request Nov 30, 2020
3 tasks
@keewis
Copy link
Collaborator Author

keewis commented Nov 30, 2020

Any ideas for how to resolve?

The only issue I have is that the signatures are inconsistent. Maybe we can switch to a explicitly passed kwargs dict instead of **kwargs for interpolate_na?

@keewis
Copy link
Collaborator Author

keewis commented Nov 30, 2020

@dcherian, this should be ready as soon as the RTD CI passes. The failing upstream-dev CI is due to trouble with installing numpy (the uploaded wheel seems to be corrupt), but I guess we can ignore that for now?

@keewis
Copy link
Collaborator Author

keewis commented Nov 30, 2020

@dcherian, this is ready for review and merging

@dcherian
Copy link
Contributor

Great improvement, thank you!

@dcherian dcherian merged commit 8c863c9 into pydata:master Nov 30, 2020
@keewis keewis deleted the extrapolation branch November 30, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpolate_na doesn't support extrapolation
3 participants