-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow customizing the inline repr of a duck array #4248
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41aa357
call the duck array's _repr_short_ method if it exists
keewis 0d42e58
rename to _repr_inline_
keewis b7f5c43
Merge branch 'master' into duckarray-short-repr
keewis 3f6f357
Merge branch 'master' into duckarray-short-repr
keewis b681404
add a crude test to make sure the object's _repr_inline_ is called
keewis 3635ff6
add a section about duck arrays
keewis fd8e9f0
update whats-new.rst
keewis 2b31131
fix a link
keewis 5cd757b
make sure the tests are not run without support for NEP18
keewis ccc9054
move the explanation for max_width into the text block
keewis 97977c2
use double instead of single quotes
keewis 6ebf3ae
add back the docstring
keewis f6161f3
link to internals in whats-new.rst
keewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add examples of what should and should not be included in
_repr_inline_
.In particular,
shape
anddtype
should not be included because xarray already adds those in a standard way.For examples of what good
_inline_repr_
look like, we could show examples of the output for dask and sparse.