-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release summary, some touch-ups #4217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Max!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, too. I have a few suggestions, though:
HOW_TO_RELEASE.md
Outdated
I (@max) find it helpful to use a PR given I'm not always familiar with all the | ||
features of the release, and the summary is distributed widely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it definitely makes sense to get a review of the summary so I'd remove this.
Instead, I'd like to suggest writing the summary as item 2, then opening a PR with the contributors, the summary and the whats-new.rst
fixes (new item 4) as item 5 to get a chance for a review and once that is merged continue with the current item 4 (after syncing again).
So now we'd have:
- sync branch
- write summary
- get the contributors (also: what should happen in the rare case that the one releasing is not included in that list?)
- check
whats-new.rst
and the docs - open a PR to add items 2 to 4 to
whats-new.rst
- resync (should that be a new step or should that also be in item 5?)
- continue with the old item 4
Does that make sense?
Updated based on @keewis good suggestions. I haven't updated the numbers until we agree it's correct. (Maybe there's some plugin to do this? Lucky we don't have a 100 item list...) |
Thanks @max-sixty |
* upstream/master: Added xarrays-spatial and updated geoviews link (pydata#4262) update docs to point to xarray-contrib and xarray-tutorial (pydata#4252) Add release summary, some touch-ups (pydata#4217) CFTimeIndex calendar in repr (pydata#4092) fix the RTD timeouts (pydata#4254) update isort CI and pre-commit hook (pydata#4204)
This PR: