Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin isort #4206

Merged
merged 3 commits into from
Jul 7, 2020
Merged

pin isort #4206

merged 3 commits into from
Jul 7, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 7, 2020 •
edited
Loading

Since the new versions of isort want to reformat import dask.array as da styled imports, this pins the isort version for now.

We can undo this in #4204 and – if we decide they're harmless – also apply the changes isort suggests.

  • Tests added
  • Passes isort -rc . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@keewis keewis changed the title pin isort for now pin isort Jul 7, 2020
@dcherian
Copy link
Contributor

dcherian commented Jul 7, 2020

Thanks @keewis

@dcherian dcherian merged commit 64c1391 into pydata:master Jul 7, 2020
@keewis keewis deleted the pin-isort branch July 7, 2020 15:18
@keewis keewis mentioned this pull request Jul 9, 2020
Merged
4 tasks
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 16, 2020
@dcherian
Merge branch 'master' into fix/4107
2b39154 
* master:
  Add initial cupy tests (pydata#4214)
  Add 0.16.0 release summary
  New whatsnew section
  Release v0.16.0
  Minor reorg of whatsnew for 0.16.0 (pydata#4216)
  fix sphinx warnings (pydata#4199)
  pin isort (pydata#4206)
  get the colorbar label via public methods (pydata#4201)
  Bump minimum versions for 0.16 release (pydata#4175)
  Allow passing axis kwargs to plot (pydata#4020)
  Fix to_unstacked_dataset for single dimension variables. (pydata#4094)
  Improve the speed of from_dataframe with a MultiIndex (by 40x!) (pydata#4184)
  More pint compatibility: silence UnitStrippedWarnings (pydata#4163)
  Fix typo (pydata#4192)
  use the latest image of RTD (pydata#4191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keewis @dcherian