Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dangerous default arguments #4006

Merged
merged 2 commits into from
May 23, 2020
Merged

fix dangerous default arguments #4006

merged 2 commits into from
May 23, 2020

Conversation

pnijhara
Copy link
Contributor

@pnijhara pnijhara commented Apr 25, 2020 •
edited
Loading

@pnijhara pnijhara closed this May 5, 2020
@pnijhara pnijhara deleted the pnijhara-patch-3 branch May 5, 2020 02:21
@pnijhara pnijhara restored the pnijhara-patch-3 branch May 6, 2020 18:01
@pnijhara pnijhara reopened this May 6, 2020
@pnijhara pnijhara force-pushed the pnijhara-patch-3 branch 2 times, most recently from a60a3f6 to 6ba6bc8 Compare May 13, 2020 15:25
@pnijhara pnijhara force-pushed the pnijhara-patch-3 branch from b02fa49 to feef24d Compare May 13, 2020 15:34
@pnijhara pnijhara requested a review from keewis May 13, 2020 15:38
keewis
keewis approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@pnijhara
Copy link
Contributor Author

@keewis are there any other changes required?

@max-sixty
Copy link
Collaborator

Sorry for the delay @pnijhara ! Merging now.

Thanks again, we're happy to have you as a contributor!

@max-sixty max-sixty merged commit 19b0886 into pydata:master May 23, 2020
@pnijhara
Copy link
Contributor Author

Thank you!

dcherian added a commit to dcherian/xarray that referenced this pull request May 25, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix-sparse
c9a4205 
* upstream/master:
  Improve interp performance (pydata#4069)
  Auto chunk (pydata#4064)
  xr.cov() and xr.corr() (pydata#4089)
  allow multiindex levels in plots (pydata#3938)
  Fix bool weights (pydata#4075)
  fix dangerous default arguments (pydata#4006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dangerous default argument
3 participants
@pnijhara @max-sixty @keewis