Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use divergent colormap if lowest and highest level span 0 #3913

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Use divergent colormap if lowest and highest level span 0 #3913

merged 4 commits into from
Apr 5, 2020

Conversation

dcherian
Copy link
Contributor

max-sixty
max-sixty approved these changes Mar 29, 2020
View reviewed changes
@dcherian dcherian merged commit 782e0e2 into pydata:master Apr 5, 2020
@dcherian dcherian deleted the div-cmap-levels branch April 5, 2020 13:41
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 5, 2020
@dcherian
Merge branch 'master' into facetgrid-cmap-params-once
2ad2183 
* master:
  Use divergent colormap if lowest and highest level span 0 (pydata#3913)
  Bugfix for plotting transposed 2d coords (pydata#3934)
  Allow plotting bool data (pydata#3766)
  facetgrid: fix case when vmin == vmax (pydata#3916)
  add a CI that tests xarray with all optional dependencies but dask (pydata#3919)
  Add missing_dims argument allowing isel() to ignore missing dimensions (pydata#3923)
  Only fail if a specific warning occurs (pydata#3930)
  Fix minor code quality issues (pydata#3626)
  Fix for stack+groupby+apply w/ non-increasing coord (pydata#3906)
  reactivate the macos CI (pydata#3920)
  add pint to the output of show_versions() (pydata#3918)
@stefraynaud
Copy link
Contributor

Two words.

It may be more appropriate to not only check that vmin and vmax are of opposite signe, but also one of them is not to close from zero, like [-0.01, 100].

This may also be extended to used positive and negative colomaps when vmin and vmax are of the same sign and one of them is close to zeros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xr.plot infers sequential colormap on diverging levels
3 participants
@dcherian @stefraynaud @max-sixty