Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template xarray object kwarg to map_blocks #3816
Add template xarray object kwarg to map_blocks #3816
Changes from 28 commits
064b583
1f14b11
045ae2b
0e37b63
5704e84
2c458e1
dced076
717d900
42a9070
64ba31f
a68cb41
0bc3754
ee66c88
d52dfd6
8ef47f6
376f242
d9029eb
6f69955
da62535
4a355e6
66fe4c4
085ce9a
0f741e2
869e62d
334e8d3
4dd699e
27eb873
04a2c3c
4b92168
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume attrs are also copied from the template and ignored from the computed chunks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But I don't know that this is right.
With auto-inferred templates, attrs are set by the user function. I think it would be nice to preserve that behaviour. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this some more... there's no way to update
attrs
after computation is there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct,
attrs
needs to be set when the resulting Dataset is created, before we do the the computation.