Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to choose mfdataset attributes source. #3498
Add option to choose mfdataset attributes source. #3498
Changes from 4 commits
702d571
f83a634
6b7d52b
a02ff9a
8cc3b34
64f9785
fb1d91f
b6b1d57
8a44831
aa62e18
aa437a4
81e1a6f
1347ab5
aa72572
175de6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is netcDF4's documentation for
master_file
:let's make it clear that unlike netCDF4 we are only using this for attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest to use a different keyword, maybe
attrs_file
?Or just clarify the difference in the docs? I don't mind.
@dcherian Thanks for the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was initially thinking of just adding a line to the docstring but we should think about renaming this to something like
attrs_from
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I've renamed it to
attrs_file
to avoid confusion with netCDF4. Thanks for pointing that. I am open to any name as long as the option is here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcherian can we mark this as resolved? The
attrs_file
now only accept a file name (see other conversation below).