Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black instructions #3195

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Update black instructions #3195

merged 1 commit into from
Aug 9, 2019

Conversation

max-sixty
Copy link
Collaborator

This needed updating with the relevant commit post-black change

I also added a line to apply the patch of manual changes we made on top of the black changes. It makes the list of steps a bit burdensome. But I've tested them a couple of times and, where people have lots of code changes, it's still going to be much easier than resolving manually.

I generally wouldn't want to suggest people curl data from the internet (even if we trust the individual). I think it's probably OK in this instance: the address contains a hash of the contents, and it's only being fed into git apply -, not executed. But lmk if that's still a security concern.

I'll update the issue I opened on black with the above issue; we should have done one commit with only the black changes, and then another with any manual changes.

@dcherian
Copy link
Contributor

dcherian commented Aug 8, 2019

These instructions worked quite well on #3175

@max-sixty max-sixty merged commit 5b36e80 into pydata:master Aug 9, 2019
@max-sixty
Copy link
Collaborator Author

Great - thanks for the update @dcherian !

@max-sixty max-sixty deleted the black branch August 9, 2019 00:27
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 9, 2019
* upstream/master:
  Ignore example.grib.0112.idx file (pydata#3198)
  small updates to the contributing.rst (it could use more) (pydata#3193)
  Remove future statements (pydata#3194)
  update instructions (pydata#3195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants