Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More support for missing_value. #2973

Merged
merged 8 commits into from
Jun 12, 2019
Merged

More support for missing_value. #2973

merged 8 commits into from
Jun 12, 2019

Conversation

dcherian
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented May 19, 2019 •
edited
Loading

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-12 15:31:36 UTC

@dcherian dcherian mentioned this pull request May 21, 2019
Closed
15 tasks
shoyer
shoyer reviewed May 27, 2019
View reviewed changes
xarray/coding/variables.py Outdated Show resolved Hide resolved
dcherian added 2 commits May 29, 2019 08:59
@dcherian
Use not equivalent instead of not equals check.
15d94f3
@dcherian
Merge remote-tracking branch 'upstream/master' into missing_value
df17e1c 
* upstream/master:
  cfgrib is now part of conda-forge (pydata#2992)
  Add fill_value for concat and auto_combine (pydata#2964)
  Remove deprecated pytest.config usages (pydata#2988)
  Add transpose_coords option to DataArray.transpose (pydata#2556)
  Fix rolling.constuct() example (pydata#2967)
  Implement load_dataset() and load_dataarray() (pydata#2917)
shoyer
shoyer approved these changes May 29, 2019
View reviewed changes
xarray/conventions.py Outdated Show resolved Hide resolved
dcherian
dcherian commented May 29, 2019
View reviewed changes
xarray/coding/variables.py Outdated Show resolved Hide resolved
dcherian
dcherian commented May 29, 2019
View reviewed changes
xarray/coding/variables.py
fill_value = pop_to(encoding, attrs, '_FillValue', name=name)
if not pd.isnull(fill_value):
data = duck_array_ops.fillna(data, fill_value)

if mv is not None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @shoyer . how about this?

@dcherian dcherian merged commit 2357851 into pydata:master Jun 12, 2019
@dcherian dcherian deleted the missing_value branch June 12, 2019 15:32
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 24, 2019
@dcherian
Merge branch 'master' into fix/bounds_encode_2
f187ca1 
* master: (31 commits)
  Add quantile method to GroupBy (pydata#2828)
  rolling_exp (nee ewm) (pydata#2650)
  Ensure explicitly indexed arrays are preserved (pydata#3027)
  add back dask-dev tests (pydata#3025)
  ENH: keepdims=True for xarray reductions (pydata#3033)
  Revert cmap fix (pydata#3038)
  Add "errors" keyword argument to drop() and drop_dims() (pydata#2994) (pydata#3028)
  More consistency checks (pydata#2859)
  Check types in travis (pydata#3024)
  Update issue templates (pydata#3019)
  Add pytest markers to avoid warnings (pydata#3023)
  Feature/merge errormsg (pydata#2971)
  More support for missing_value. (pydata#2973)
  Use flake8 rather than pycodestyle (pydata#3010)
  Pandas labels deprecation (pydata#3016)
  Pytest capture uses match, not message (pydata#3011)
  dask-dev tests to allowed failures in travis (pydata#3014)
  Fix 'to_masked_array' computing dask arrays twice (pydata#3006)
  str accessor (pydata#2991)
  fix safe_cast_to_index (pydata#3001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xr.open_dataset(f1).to_netcdf(file2) is not idempotent
3 participants
@dcherian @pep8speaks @shoyer