Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Pass kwargs to the FileManager for pynio engine (#2380) #2732

Merged
merged 4 commits into from
Feb 7, 2019
Merged

BUG: Pass kwargs to the FileManager for pynio engine (#2380) #2732

merged 4 commits into from
Feb 7, 2019

Conversation

jonmjoyce
Copy link
Contributor

@jonmjoyce jonmjoyce commented Jan 31, 2019 •
edited
Loading

@mathause mathause mentioned this pull request Feb 1, 2019
Closed
@shoyer
Copy link
Member

shoyer commented Feb 1, 2019

Could we add a simple regression test for this? Just an example test that passing some keyword argument through to pynio.

@jonmjoyce
Copy link
Contributor Author

I would like to, but honestly I'm pretty new to Python and didn't understand how the tests worked. I found the TestPyNio class and assume I would add something there but I currently have no idea how to test in Python. I tested manually with this code:
xarray.open_dataset(filename, engine='pynio', backend_kwargs={"format":"grib2"})

I'm sure I can figure it out in time (C# and Java background) but any guidance is appreciated.

@pep8speaks
Copy link

pep8speaks commented Feb 5, 2019 •
edited
Loading

Hello @jonmjoyce! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 07, 2019 at 02:56 Hours UTC

@shoyer shoyer merged commit 0dfc0e6 into pydata:master Feb 7, 2019
@shoyer
Copy link
Member

shoyer commented Feb 7, 2019

thanks @jonmjoyce !

@jonmjoyce jonmjoyce deleted the pynio_kwargs branch February 7, 2019 20:24
dcherian pushed a commit to yohai/xarray that referenced this pull request Feb 14, 2019
Merge branch 'master' into yohai-ds_scatter
0c20fc8 
* master:
  typo in whats_new (pydata#2763)
  Update computation.py to use Python 3 function signatures (pydata#2756)
  add h5netcdf+dask tests (pydata#2737)
  Fix name loss when masking (pydata#2749)
  fix datetime_to_numeric and Variable._to_numeric (pydata#2668)
  Fix mypy errors (pydata#2753)
  enable internal plotting with cftime datetime (pydata#2665)
  remove references to cyordereddict (pydata#2750)
  BUG: Pass kwargs to the FileManager for pynio engine (pydata#2380) (pydata#2732)
  reintroduce pynio/rasterio/iris to py36 test env (pydata#2738)
  Fix CRS being WKT instead of PROJ.4 (pydata#2715)
  Refactor (part of) dataset.py to use explicit indexes (pydata#2696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonmjoyce @shoyer @pep8speaks