Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swap_coords to relevant 'See also' sections #2463

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

nedclimaterisk
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Oct 4, 2018

Hello @nedclimaterisk! Thanks for updating the PR.

Line 209:80: E501 line too long (90 > 79 characters)
Line 429:80: E501 line too long (82 > 79 characters)
Line 465:80: E501 line too long (86 > 79 characters)
Line 468:80: E501 line too long (84 > 79 characters)
Line 472:80: E501 line too long (81 > 79 characters)
Line 473:80: E501 line too long (87 > 79 characters)
Line 486:80: E501 line too long (82 > 79 characters)
Line 496:80: E501 line too long (80 > 79 characters)
Line 505:80: E501 line too long (80 > 79 characters)
Line 527:80: E501 line too long (84 > 79 characters)
Line 560:80: E501 line too long (80 > 79 characters)
Line 564:80: E501 line too long (81 > 79 characters)
Line 568:80: E501 line too long (85 > 79 characters)
Line 632:80: E501 line too long (81 > 79 characters)
Line 636:80: E501 line too long (85 > 79 characters)
Line 643:80: E501 line too long (86 > 79 characters)
Line 649:80: E501 line too long (86 > 79 characters)
Line 656:80: E501 line too long (89 > 79 characters)
Line 706:23: E122 continuation line missing indentation or outdented
Line 822:80: E501 line too long (80 > 79 characters)

Line 729:80: E501 line too long (81 > 79 characters)
Line 740:80: E501 line too long (80 > 79 characters)
Line 758:80: E501 line too long (88 > 79 characters)
Line 769:80: E501 line too long (84 > 79 characters)
Line 778:80: E501 line too long (84 > 79 characters)
Line 785:80: E501 line too long (80 > 79 characters)
Line 801:80: E501 line too long (84 > 79 characters)
Line 818:80: E501 line too long (80 > 79 characters)
Line 1097:80: E501 line too long (81 > 79 characters)
Line 1207:80: E501 line too long (92 > 79 characters)
Line 1386:80: E501 line too long (92 > 79 characters)
Line 1422:71: W291 trailing whitespace
Line 1645:80: E501 line too long (82 > 79 characters)
Line 1784:80: E501 line too long (82 > 79 characters)
Line 1887:80: E501 line too long (80 > 79 characters)
Line 1888:80: E501 line too long (80 > 79 characters)
Line 1998:16: E111 indentation is not a multiple of four
Line 2005:1: W293 blank line contains whitespace
Line 2192:80: E501 line too long (80 > 79 characters)
Line 2277:80: E501 line too long (80 > 79 characters)
Line 2995:80: E501 line too long (86 > 79 characters)
Line 3002:80: E501 line too long (82 > 79 characters)
Line 3044:80: E501 line too long (80 > 79 characters)
Line 3762:80: E501 line too long (80 > 79 characters)
Line 3843:80: E501 line too long (83 > 79 characters)
Line 3921:80: E501 line too long (82 > 79 characters)
Line 3927:80: E501 line too long (84 > 79 characters)
Line 3938:80: E501 line too long (82 > 79 characters)
Line 3941:80: E501 line too long (88 > 79 characters)
Line 3942:80: E501 line too long (83 > 79 characters)

Comment last updated on October 05, 2018 at 00:04 Hours UTC

Copy link
Member

@fujiisoup fujiisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nedclimaterisk

Please do not mind a comment from pep8speaks.
I found a typo.

@@ -344,6 +344,7 @@ def assign_coords(self, **kwargs):
See also
--------
Dataset.assign
Dataset.swap_coords
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are swap_dims not swap_coords.

@nedclimaterisk
Copy link
Contributor Author

whoops, sorry, fixed that commit.

@fmaussion fmaussion mentioned this pull request Oct 6, 2018
1 task
@dcherian dcherian merged commit f9f4903 into pydata:master Oct 23, 2018
@dcherian
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants