Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for vectorize=True in apply_ufunc with old numpy #1963

Merged
merged 4 commits into from
Mar 7, 2018

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Mar 5, 2018

  • Closes numpy 1.11 support for apply_ufunc #1956 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

Copy link
Member

@fujiisoup fujiisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@@ -3,6 +3,7 @@

NOT PUBLIC API.
"""
from distutils.version import LooseVersion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W1618 import missing from __future__ import absolute_import

Copy link
Member

@fujiisoup fujiisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoyer shoyer merged commit 870e4ea into pydata:master Mar 7, 2018
@shoyer shoyer deleted the old-numpy-error branch March 7, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants