-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ISSUE_TEMPLATE for github and xr.show_versions() #1485
Conversation
This is a good idea! But it is going to be a mess until a new version of xarray is released, since users won't have access to the utility function... |
Good point. I guess we could hold off on merging for a bit then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's either hold off on merging this until shortly before the next xarray release, or merge everything except the issue template.
xarray/util/print_versions.py
Outdated
("xarray", lambda mod: mod.__version__), | ||
("pandas", lambda mod: mod.__version__), | ||
("numpy", lambda mod: mod.version.version), | ||
("scipy", lambda mod: mod.version.version), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use mod.__version__
for numpy and scipy? That's the more standard way to access this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that works. Done.
Let's just wait until we have our next release. |
git diff upstream/master | flake8 --diff
whats-new.rst
for all changes andapi.rst
for new APIThis PR adds a new module level function
xr.show_versions()
and a new Github Issue Template to help with debugging user issues. Hopefully, we stop having to ask "what version of dask are you using?" Functionality is copied from pandas.