Fix missing config errors when running test suite #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH1358, GH1353 The approach I took here is to *not* package `conftest.py` with the xarray distribution, but rather make the test suite robust to it's absence. Also, as suggested by QuLogic in GH1336, switched from using a custom decorator for `--run-slow` to just using `@pytest.mark.slow`. Finally, I speed-up the test_dataset.test_rolling_reduce tests (from ~55 to ~17 seconds when bottleneck is not installed) and marked them as slow. It would be nice to get them running in a few seconds or less, but we can save that for later. On my laptop, the whole test suite now runs with `-k 'not slow'` in 36 seconds, which is not great, but acceptable. CC pwolfram jhamman ghisvail
pwolfram
approved these changes
Apr 11, 2017
| # Can't get config from pytest, e.g., because xarray is installed instead | ||
| # of being run from a development version (and hence conftests.py is not | ||
| # available). Don't run flaky tests. | ||
| _SKIP_FLAKY = True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1358, #1353
The approach I took here is to not package
conftest.pywith the xarray distribution, but rather make the test suite robust to it's absence.Also, as suggested by @QuLogic in #1336, switched from using a custom decorator for
--run-slowto just using@pytest.mark.slow.Finally, I speed-up the test_dataset.test_rolling_reduce tests (from ~55 to ~17 seconds when bottleneck is not installed) and marked them as slow. It would be nice to get them running in a few seconds or less, but we can save that for later. On my laptop, the whole test suite now runs with
-k 'not slow'in 36 seconds, which is not great, but acceptable.CC @pwolfram @jhamman @ghisvail
git diff upstream/master | flake8 --diff