Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks slow, flaky, and failing tests #1336

Merged
merged 9 commits into from
Apr 3, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ matrix:
env: CONDA_ENV=py35
- python: 3.6
env: CONDA_ENV=py36
- python: 3.6
env:
- CONDA_ENV=py36
- EXTRA_FLAGS="--run-flaky"
- python: 3.6
env: CONDA_ENV=py36-pydap
- python: 3.6
Expand All @@ -36,6 +40,10 @@ matrix:
- python: 3.6
env: CONDA_ENV=py36-condaforge-rc
allow_failures:
- python: 3.6
env:
- CONDA_ENV=py36
- EXTRA_FLAGS="--run-flaky"
- python: 3.6
env: CONDA_ENV=py36-pydap
- python: 3.6
Expand Down Expand Up @@ -76,7 +84,7 @@ install:
- python setup.py install

script:
- py.test xarray --cov=xarray --cov-report term-missing --verbose
- py.test xarray --cov=xarray --cov-report term-missing --verbose $EXTRA_FLAGS

after_success:
- coveralls
17 changes: 9 additions & 8 deletions ci/requirements-py27-cdat+pynio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,20 @@ channels:
dependencies:
- python=2.7
- cdat-lite
- cyordereddict
- dask
- distributed
- pytest
- h5py
- h5netcdf
- matplotlib
- netcdf4
- numpy
- pandas>=0.15.0
- pandas
- pynio
- netcdf4
- pytest
- scipy
- pytest-cov
- cyordereddict
- h5py
- netcdf4
- matplotlib
- seaborn
- toolz
- pip:
- coveralls
- pytest-cov
10 changes: 7 additions & 3 deletions ci/requirements-py27-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@ channels:
dependencies:
- python=2.7
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netCDF4
- netcdf4
- pytest
- numpy
- pandas
- pip
- pytest
- scipy
- seaborn
- toolz
6 changes: 3 additions & 3 deletions ci/requirements-py35.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ channels:
- conda-forge
dependencies:
- python=3.5
- cython
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netcdf4
- pytest
- numpy
- pandas
- seaborn
- scipy
- seaborn
- toolz
- pip:
- coveralls
- pytest-cov
- h5netcdf
4 changes: 2 additions & 2 deletions ci/requirements-py36-condaforge-rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ channels:
- conda-forge
dependencies:
- python=3.6
- cython
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netcdf4
- pytest
- numpy
- pandas
- seaborn
- scipy
- toolz
- pip:
- coveralls
- pytest-cov
- h5netcdf
9 changes: 7 additions & 2 deletions ci/requirements-py36-dask-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@ channels:
- conda-forge
dependencies:
- python=3.6
- cython
- h5py
- h5netcdf
- matplotlib
- netcdf4
- pytest
- numpy
- pandas
- seaborn
- scipy
- toolz
- pip:
- coveralls
- pytest-cov
- git+https://github.com/blaze/dask.git
- git+https://github.com/dask/dask.git
- git+https://github.com/dask/distributed.git
4 changes: 3 additions & 1 deletion ci/requirements-py36-netcdf4-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ dependencies:
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- pytest
- numpy
- pandas
- scipy
- toolz
- pip:
- coveralls
- pytest-cov
- h5netcdf
- git+https://github.com/Unidata/netcdf4-python.git
14 changes: 9 additions & 5 deletions ci/requirements-py36-pandas-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@ channels:
- conda-forge
dependencies:
- python=3.6
- cython=0.23.4
- cython
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netcdf4
- pytest
- numpy=1.10.1
- netcdf4=1.1.9
- scipy=0.16.0
- numpy
- scipy
- toolz
- pip:
- coveralls
- pytest-cov
- dask
- git+https://github.com/pydata/pandas.git
4 changes: 3 additions & 1 deletion ci/requirements-py36-pydap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ dependencies:
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netcdf4
- pytest
- numpy
- pandas
- scipy
- toolz
- pip:
- coveralls
- pytest-cov
Expand Down
10 changes: 7 additions & 3 deletions ci/requirements-py36-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@ channels:
dependencies:
- python=3.6
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netCDF4
- netcdf4
- pytest
- numpy
- pandas
- pip
- pytest
- scipy
- seaborn
- toolz
6 changes: 3 additions & 3 deletions ci/requirements-py36.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ channels:
- conda-forge
dependencies:
- python=3.6
- cython
- dask
- distributed
- h5py
- h5netcdf
- matplotlib
- netcdf4
- pytest
- numpy
- pandas
- seaborn
- scipy
- seaborn
- toolz
- pip:
- coveralls
- pytest-cov
- h5netcdf
9 changes: 9 additions & 0 deletions conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
"""Configuration for pytest."""


def pytest_addoption(parser):
"""Add command-line flags for pytest."""
parser.addoption("--run-flaky", action="store_true",
help="runs flaky tests")
parser.addoption("--skip-slow", action="store_true",
help="skips slow tests")
5 changes: 5 additions & 0 deletions doc/whats-new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ By `Henry S. Harrison <https://hsharrison.github.io>`_.
cleaner output. The full metadata is still available as ``data.attrs``.
By `Zac Hatfield-Dodds <https://github.com/Zac-HD>`_.

- Enhanced tests suite by use of ``@slow`` and ``@flaky`` decorators, which are
controlled via ``--run-flaky`` and ``--skip-slow`` command line arguments
to ``py.test``. By `Stephan Hoyer <https://github.com/shoyer>`_ and
`Phillip J. Wolfram <https://github.com/pwolfram>`_.

Bug fixes
~~~~~~~~~
- ``rolling`` now keeps its original dimension order (:issue:`1125`).
Expand Down
9 changes: 9 additions & 0 deletions xarray/tests/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,15 @@ def requires_bottleneck(test):
return test if has_bottleneck else pytest.mark.skip('requires bottleneck')(test)


flaky = pytest.mark.skipif(
not pytest.config.getoption("--run-flaky"),
reason="set --run-flaky option to run flaky tests")

slow = pytest.mark.skipif(
pytest.config.getoption("--skip-slow"),
reason="set --skip-slow option to run slow tests")


class TestCase(unittest.TestCase):
if PY3:
# Python 3 assertCountEqual is roughly equivalent to Python 2
Expand Down
Loading