Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch AppVeyor CI to use conda env / requirements.yml #1274

Merged
merged 2 commits into from
Feb 20, 2017

Conversation

spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Feb 17, 2017

@shoyer here I'm reusing existing requirements files. Is this along the lines of what you were looking for in #1127?

I think this should solve the AppVeyor test failures in #1252, as it should install version 1.2.7 of netCDF4, rather than version 1.2.4.

@spencerkclark
Copy link
Member Author

@shoyer it's entirely possible I'm in over my head here, as I'm not a Windows user, so I can't test this setup locally. It looks as though using the existing requirements files (which install more than what was specified in the original appveyor.yml configuration file) was probably not a good idea.

If it's a matter of simply creating new requirements files for the Windows environments to mirror what was installed in the original appveyor.yml file, i.e. pip, pytest, numpy, pandas, scipy, netCDF4, matplotlib, and dask, (this time using the conda-forge channel) then I can probably handle that, but anything more is guesswork on my end, so I'd be fine closing this PR. I was hoping for a straightforward fix.

@shoyer
Copy link
Member

shoyer commented Feb 17, 2017

If it's a matter of simply creating new requirements files for the Windows environments to mirror what was installed in the original appveyor.yml file, i.e. pip, pytest, numpy, pandas, scipy, netCDF4, matplotlib, and dask, (this time using the conda-forge channel) then I can probably handle that

Yes, this is what I would recommend. It's just a little easier to maintain if we keep the requirements separate from the install script.

@spencerkclark
Copy link
Member Author

Cool, I think I have things working now. Please let me know if you'd like me to make any changes.

@shoyer shoyer merged commit 94342d5 into pydata:master Feb 20, 2017
@shoyer
Copy link
Member

shoyer commented Feb 20, 2017

Looks great, thanks!

@spencerkclark spencerkclark deleted the update-appveyor branch February 21, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Appveyor CI configuration to use conda env / requirements.yml
2 participants