Only run fast unstack on numpy arrays

pydata · Jan 3, 2021 · 88eb42e · 88eb42e
1 parent 9a53fec
commit 88eb42e
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/xarray/core/dataset.py b/xarray/core/dataset.py
@@ -3849,6 +3849,18 @@ def unstack(
                 or sparse
                 # numpy full_like only added `shape` in 1.17
                 or LooseVersion(np.__version__) < LooseVersion("1.17")
+                # Until https://github.com/pydata/xarray/pull/4751 is resolved,
+                # we check explicitly whether it's a numpy array. Once that is
+                # resolved, explicitly exclude pint arrays.
+                # # pint doesn't implement `np.full_like` in a way that's
+                # # currently compatible.
+                # # https://github.com/pydata/xarray/pull/4746#issuecomment-753425173
+                # # or any(
+                # #     isinstance(v.data, pint_array_type) for v in self.variables.values()
+                # # )
+                or any(
+                    not isinstance(v.data, np.array) for v in self.variables.values()
+                )
             ):
                 result = result._unstack_full_reindex(dim, fill_value, sparse)
             else: