This adds the mastodon fediverse icon as own option.

[albig]

This adds the mastodon icon as own option mastodon_url as Mastodon seems to get more popular now.

Of course, this could be done already right now with

html_theme_options = {
  "icon_links": [
    {
        "name": "Mastodon",
        "url": "https://gruene.social/@albigdd",
        "icon": "fab fa-mastodon",
    },
  ],
}

[choldgraf]

Hmmm - I think we are actually moving away from these shortcuts so that we don't have a bunch of special-cases in there. Maybe instead you could just provide an example of how to add a mastadon button in the docs?

[albig]

Ah, ok. Thank you.

Then I'll change my PR later to just add some information to the documentation.

[choldgraf]

This LGTM if you're ready to go!

[albig]

From my part, it would be ready.

I thought about to add a possibility to add a rel="me" or extend the current rel attribute to rel="noopener me", but not absolutely sure about. Mastodon suggests to do this.

• https://microformats.org/wiki/rel-me
• https://blog.joinmastodon.org/2018/10/mastodon-2.6-released/

What do you think? Would it be worth doing this in another PR?

[choldgraf]

That is pretty cool - I hadn't heart about that before. Hmm, maybe the way to do this would be to support other key: val pairs in the icon links config, that would be added to the "a" anchor, and this could be used to add stuff like rel=me?

[albig]

I think, this would be the proper way to go. A configuration like this would be great:

html_theme_options = {
  "icon_links": [
    {
        "name": "Mastodon",
        "url": "https://gruene.social/@albigdd",
        "icon": "fab fa-mastodon",
        "rel": "noopener me",
    },
  ],
}

If no "rel" is set, the default rel="noopener" should be set.

[choldgraf]

I think that'd be fine as long as we don't imagine any other kinds of config being added to the "a" element. But if we do think other config would be added, we should just add a general extension mechanism for key: value pairs so that we don't grow the config surface area too much

[albig]

What do you think about something like additionalAttributes like TYPO3 Fluid template engine is using.

The idea is to add additional attributes which have no own config field.

E.g.

html_theme_options = {
  "icon_links": [
    {
        "name": "Mastodon",
        "url": "https://gruene.social/@albigdd",
        "icon": "fab fa-mastodon",
        "additionalattributes": [
             "rel": "noopener me",
             "target": "_blank"
        ]
     },
  ],
}

[choldgraf]

That sounds great to me 👍

[choldgraf]

I'll merge this one in as-is, and we can tackle custom attributes etc in a follow-up if you wish!