-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a url type for navbar icons #616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty good to me! One quick typo I found but it looks good in general. Just to be clear, the CSS and behavior is no different from the "local" use-case right? If that's the case it's probably not a big deal that we don't demo this in our theme documentation .
also I think you'll need to update one of the regression tests just FYI!
You're right, no change in CSS and behavior. So I've merged the Local Image Icons and URL Icons (the section I added originally) into an Image Icons section. I think it's still worth documenting it. |
I think this one looks good to go in my opinion. The failing tests were because the pre-commit hook had the wrong black dependency specified. I've updated that on |
Sure let's see if now they pass :) I've merged master. |
I've made a slight modification to the docs to fix a failing test and to help separate out the |
many thanks for the improvement @maximlt ! |
Partially addresses #603