Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: New action for lighthouse #572

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Jan 18, 2022

This uses a different lighthouse action where we can automatically preview the report from within GitHub Actions.

It doesn't touch the pa11y stuff - we can hash that out in other issues etc.

This supercedes #548 (because a rebase was confusing me and I wanted to reduce the scope of the PR anyway)

closes #546

Copy link
Collaborator

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the reduction of the scope, this one LGTM.

@choldgraf choldgraf merged commit 8453f38 into pydata:master Feb 3, 2022
@choldgraf choldgraf deleted the MAINT-lighthouse-2 branch February 3, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the GitHub Action for Lighthouse rather than manually running it
2 participants