Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark theme and theme switcher #540
Add dark theme and theme switcher #540
Changes from all commits
07e416b
932844e
2469f07
f0cccbe
9850073
338a1b5
a1d9865
6f50e5a
df23c55
84338de
5e3f3a5
81a2117
bf6044b
c59735c
25a8e1e
03a84ee
951a316
7342f64
06ab359
3b36764
9ecd5e4
31f7c5e
5b1452d
ecdf638
8eb2c1e
36445bc
3e07469
a474db1
c822508
2c28826
e107a14
5bb58c3
fec703b
06c7e13
34b3934
17409bf
9b13e31
8413144
1406d1f
ba3e59a
82c2e79
a2aaf68
0f9f477
80cb20e
e4c68a4
43ceb27
4b6f568
1bff226
5220fb9
ba04a68
48d3d6b
1a45cc7
02f185c
df22fc2
27e7bd6
5ef0ac3
45860d7
decac66
45d65c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future, how do you envision new light and dark modes using new themes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no more than 2 themes at the time should be used in documentation.
If we want to add extra themes in the lib (high contrast, color-blind friendly etc...) I think we should select a different theming file at build time. For this purpose, we could split dark and light default theme in 2 files and add 2 parameters (or 1 dict) in the
conf.py
file.