Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: update role for caption in expected html output (sphinx 4.1) #441

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Aug 9, 2021

Sphinx 4.1 added a role="heading" to the caption <p> (sphinx-doc/sphinx#9358), so this updates the expected output to get CI passing again.

In general, do we have some way to deal with such cross-sphinx-version differences? Or just test the output with the latest sphinx and ensure the expected html is up to date with that? (although ideally we would test against multiple sphinx versions?)

Closes #437

This was referenced Aug 9, 2021
@drammock
Copy link
Collaborator

drammock commented Aug 9, 2021

In general, do we have some way to deal with such cross-sphinx-version differences? [...] ideally we would test against multiple sphinx versions

This ought to be possible by specifying different sphinx versions in some of your CI recipes, and decorating some tests with pytest fixtures so they get skipped if the testing environment doesn't have the right sphinx version.

@jorisvandenbossche
Copy link
Member Author

Yes, that would indeed be possible.

Now, already going to merge this PR since that makes some more builds green, as long as we are only testing for "latest sphinx". Will open another issue for multi-sphinx-version testing/support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidebar tests failing
2 participants