Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section with subpages to demo docs + fix hover styling #300

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

jorisvandenbossche
Copy link
Member

We didn't yet have this in our demo docs, so making it difficult to check new PRs related to this feature.
And while adding it, I noticed the "hover" styling was inconsistent for the subpages in the sidebar nav.

@@ -317,6 +317,12 @@ table.field-list {
padding: 0.25rem 1.5rem;
font-size: 0.9em;
color: rgba(var(--color-sidebar-link), 1);

&:hover {
color: rgba(var(--color-sidebar-link-hover), 1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not the most robust way for doing this (also only works for 1 level of additional nesting), but since this is already done like that for the other style elements, this is the quick fix.
But we should probably rework this part a bit more general.

@jorisvandenbossche
Copy link
Member Author

Going to merge this because I want to test it in #219 (but feedback still welcome of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant