-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/anchor all elements #283
Feature/anchor all elements #283
Conversation
very cool, I didn't know about this target selector, is it consistent across browsers? |
Supprisingly yes. I also learned about it thanks to @jorisvandenbossche 's research. |
Cool! @hoetmaaiers it seems you have a conflict (because the actual The change from 80 to 60px offset is intentional? (it looks fine on the demo docs for this PR) |
The merge conflicts are resolved now. The choice for 60px is indeed on purpose. This leave some extra white space at the top without the anchor element being smacked to the edge. |
Grmbl, the merge resolution made the 'lint' check fail. @choldgraf or @jorisvandenbossche I always struggle with this check. Is it a problem with indentation or alike? |
@hoetmaaiers the issue was that |
this LGTM! and the tests are now passing with @jorisvandenbossche 's fix 🚀 |
Update to match all anchor elements with
:target
talked about in #280 .