-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 MAINT: special-casing xarray output CSS #275
Conversation
I am not sure why the https://pydata-sphinx-theme--275.org.readthedocs.build/en/275/demo/demo.html#html @jorisvandenbossche any idea what's going on? |
OK I think I figured out what was up (I needed to re-install pre-commit and rebuild with Yarn). Gonna merge this if the tests are happy so we get this 🐛 fixed |
I was just cleaning it up locally and pushing, but you just pushed already ;) So for some reason you had different versions of the libraries we vendor, and so those vendored assets got updated. Not sure how that happend, but what I did locally to clean it up: In my env:
(that second step also happens in the pre-commit) |
oops I just saw this! Sorry for merging 😬 but I re-pushed and all the extra fonts files went away so I figured it was OK to merge. LMK if you'd like me to revert |
No, I was just saying that you did exactly the same as I did, so for sure fine to merge it ;) |
@jorisvandenbossche I am gonna try following the steps that you just shared over in #263 and seeing if that accomplishes the same thing...we may wanna update those fonts etc but I feel that it should be in its own standalone PR |
Indeed, and we actually were planning to remove some? cfr #247 |
Just stopping by to say thank you for doing this! |
closes #274