Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINT: special-casing xarray output CSS #275

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

choldgraf
Copy link
Collaborator

closes #274

@choldgraf
Copy link
Collaborator Author

I am not sure why the lint job is failing, since the CSS files seem properly linked in the demo docs. Here's the output:

https://pydata-sphinx-theme--275.org.readthedocs.build/en/275/demo/demo.html#html

@jorisvandenbossche any idea what's going on?

@choldgraf
Copy link
Collaborator Author

OK I think I figured out what was up (I needed to re-install pre-commit and rebuild with Yarn). Gonna merge this if the tests are happy so we get this 🐛 fixed

@jorisvandenbossche
Copy link
Member

I was just cleaning it up locally and pushing, but you just pushed already ;)

So for some reason you had different versions of the libraries we vendor, and so those vendored assets got updated. Not sure how that happend, but what I did locally to clean it up:

In my env:

# ensure all versions are as specified in the repo
yarn 
# rebuild
yarn build:production

(that second step also happens in the pre-commit)

@choldgraf choldgraf changed the title special-casing xarray output CSS 🔧 MAINT: special-casing xarray output CSS Oct 23, 2020
@choldgraf choldgraf merged commit 395ce3b into pydata:master Oct 23, 2020
@choldgraf choldgraf deleted the xarray branch October 23, 2020 19:25
@choldgraf
Copy link
Collaborator Author

oops I just saw this! Sorry for merging 😬 but I re-pushed and all the extra fonts files went away so I figured it was OK to merge. LMK if you'd like me to revert

@jorisvandenbossche
Copy link
Member

No, I was just saying that you did exactly the same as I did, so for sure fine to merge it ;)

@choldgraf
Copy link
Collaborator Author

@jorisvandenbossche I am gonna try following the steps that you just shared over in #263 and seeing if that accomplishes the same thing...we may wanna update those fonts etc but I feel that it should be in its own standalone PR

@jorisvandenbossche
Copy link
Member

we may wanna update those fonts etc but I feel that it should be in its own standalone PR

Indeed, and we actually were planning to remove some? cfr #247

@dcherian
Copy link

Just stopping by to say thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special-case xarray so that its repr_html shows up
3 participants