Fix colour variables #2058
Merged
Fix colour variables #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
kind: bug
Coverage report
This PR does not seem to contain any modification to coverable code. |
drammock
approved these changes
Nov 28, 2024
|
Hm, "broken" or no, |
|
Since this was a rather quick addition I opened a PR already at #2082 |
trallard
added a commit
that referenced
this pull request
Dec 17, 2024
Nick pointed in #2058 (comment) that the `--pst-heading-color` variable is used by folks to customise the headings colour (this was the colour variable before #2058 which brought this in line with our naming convention `--pst-color-heading`). This change effectively renders the use of `--pst-heading-color` useless, so this PR adds a fallback mechanism for this variable. I also added a note about `--pst-color-heading` being our preferred variable. This is not a "big" breaking change, but it will likely affect folks who do not have their PST version pinned since I just made a release. So, it might be worth publishing this change in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the design system documentation, we noticed some fixes needed:
--pst-color-panel-backgroundfor the background of the card (introduced in Add panels support #641, but it seems this was removed later and it was not properly replaced). Since cards are meant to give some sense of elevation, I replaced this with--pst-color-on-background, which mostly applies to thedarktheme (see screenshots below)Current colour:
In this PR:
light theme- it's the same before and after as we rely on shadows for elevationcc @smeragoel