-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS to allow scrolling of ipywidget #1760
Conversation
Related: 1041 and this PR address two related but different scenarios. They both deal with notebook cell outputs. But this PR deals specifically when the cell output uses ipywidgets. 1041 put an This PR, on the other hand, has to override an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-review
// ipywidgets | ||
.jp-OutputArea-output.lm-Widget { | ||
// override overflow:hidden rule from Lumino (.lm-Widget) to allow scrolling | ||
overflow: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure if I should set auto
for both x and y or just x, but I decided to follow JupyterLab's lead, though to be honest I'm not entirely sure if the scenario described in jupyterlab/jupyterlab#6104 is applicable or not to sites built with PyData Sphinx Theme.
// ipywidgets | ||
.jp-OutputArea-output.lm-Widget { | ||
// override overflow:hidden rule from Lumino (.lm-Widget) to allow scrolling | ||
overflow: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I tested that this works for both nbsphinx and myst-nb (works = allows horizontal scrolling for wide table inside an ipywidget).
I'm wondering if there's some way to test this automatically, or if we could build two example pages from the same identical notebook, one through myst-nb and the other through nbsphinx.
Ok, let's get this one in to get feedback |
This addresses one of the issues in pydata#1740: missing horizontal scrollbar. - Add CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
This addresses one of the issues in pydata#1740: missing horizontal scrollbar. - Add CSS rule to allow scrolling - Add ipywidgets example to the examples/pydata page
This PR addresses one of the issues in #1740: missing horizontal scrollbar.
Changes: