Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style keyword arguments in API docs #1323

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

timhoffm
Copy link
Contributor

They are now slightly muted and not bold anymore.
This draws more attention to the parameter names
and should make it easier to read long parameter
lists.

before:
grafik

after:
grafik

They are now slightly muted and not bold anymore.
This draws more attention to the parameter names
and should make it easier to read long parameter
lists.
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like @trallard to sign off on this before merging, as it interacts with work in #1174

@trallard
Copy link
Collaborator

This change should be fine since it is using the muted text variable and should have enough contrast anyway.
I'd say let's merge it and I will double-check it on top of the colours PR (that I need to finish soon).

@drammock drammock merged commit 97757a1 into pydata:main May 13, 2023
@drammock
Copy link
Collaborator

Thanks @timhoffm and @trallard !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants