Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hovering on monospaced links changes underline color but not text color #2006

Closed
drammock opened this issue Oct 7, 2024 · 0 comments · Fixed by #2007
Closed

hovering on monospaced links changes underline color but not text color #2006

drammock opened this issue Oct 7, 2024 · 0 comments · Fixed by #2007

Comments

@drammock
Copy link
Collaborator

drammock commented Oct 7, 2024

Not sure if that is intentional or not? You can see this by hovering a function name on https://scikit-learn.org/stable/api/index.html for example.

trallard pushed a commit that referenced this issue Oct 16, 2024
I decided to assume that #2006 was in fact a bug, so here's a fix. If
it's *not* a bug, we can easily alter this PR to keep the test and
discard the CSS change.

also includes a small tweak to the existing "breadcrumbs-everywhere"
test: ~~putting much less in the `try` block so that it might actually
fail in cases where we would want it to fail.~~ *being more explicit
about what we expect to sometimes fail, by moving some code out of the
`try` block and into an `else` block*

closes #2006
@Carreau Carreau added this to the Empty milestone. milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants