Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version switcher not opening on mobile #1340

Closed
aplowman opened this issue May 28, 2023 · 3 comments · Fixed by #1342
Closed

Version switcher not opening on mobile #1340

aplowman opened this issue May 28, 2023 · 3 comments · Fixed by #1342
Assignees
@alphapapa
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship

Comments

@aplowman
Copy link

The version switcher dropdown does not appear to open properly on mobile. See the below GIF where I initially show the version switcher working in "desktop mode", I then shrink the window width and try to open the version switcher dropdown. This is in Edge 115.0.1866.1. I see the same thing in Chrome 113.0.5672.127, and in Firefox 113.0.2; all on Windows 10.

pdst-vers-switcher-edge 115 0 1866 1

@stefanv
Copy link

stefanv commented Jun 2, 2023

I can confirm this.

@alphapapa
Copy link
Contributor

@stefanv I got your email. I'd be glad to look into this.

Would someone please assign the issue to me to help me track what I'm assigned to? Thanks.

alphapapa added a commit to alphapapa/pydata-sphinx-theme that referenced this issue Jun 6, 2023
@alphapapa
fix: version switcher on sidebar (pydata#1340)
4449ef8 
Fixes pydata#1340.  Thanks to Adam Plowman (@aplowman) for reporting.
@alphapapa alphapapa mentioned this issue Jun 6, 2023
Merged
@alphapapa
Copy link
Contributor

Please see #1342 for the fix.

@12rambau 12rambau added the impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship label Jun 7, 2023
12rambau pushed a commit that referenced this issue Jun 8, 2023
@alphapapa
fix: version switcher on sidebar (#1342)
d6fdd8b 
Fixes #1340.  Thanks to Adam Plowman (@aplowman) for reporting.
@drammock drammock mentioned this issue Jun 8, 2023
Closed
@tikkss tikkss mentioned this issue Sep 17, 2023
Closed
@kou kou mentioned this issue Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: version switcher on sidebar (#1340) alphapapa/pydata-sphinx-theme
4 participants
@stefanv @alphapapa @aplowman @12rambau