refactor bugfix #201

pydata · Jan 4, 2019 · 3dec62b · 3dec62b
1 parent 25402b7
commit 3dec62b
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/bottleneck/src/reduce_template.c b/bottleneck/src/reduce_template.c
@@ -1219,7 +1219,6 @@ reducer(char *name,
     int dtype;
     int ddof;
     int reduce_all = 0;
-    int decref_a = 0;
 
     PyArrayObject *a;
     static PyObject *y;
@@ -1235,12 +1234,12 @@ reducer(char *name,
     /* convert to array if necessary */
     if PyArray_Check(a_obj) {
         a = (PyArrayObject *)a_obj;
+        Py_INCREF(a);
     } else {
         a = (PyArrayObject *)PyArray_FROM_O(a_obj);
         if (a == NULL) {
             return NULL;
         }
-        decref_a = 1;
     }
 
     /* check for byte swapped input array */
@@ -1328,9 +1327,7 @@ reducer(char *name,
 
     }
 
-    if (decref_a == 1) {
-        Py_DECREF(a); \
-    }
+    Py_DECREF(a);
 
     return y;