fix: superfluous deep env conflicts with non-dict model leaf #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test setup seems broken for mac/python 3.8/3.9 |
Got fixed in a4aadfd |
If a model defines a leaf as e.g. a string and the user or system sets an environment var with an additional `env_nested_delimiter + suffix`, `explode_env_vars` was treating the string as a `dict` (trying to add an item to it). This fix checks if the target is indeed a `dict`. In that regard, the whole `explode_env_vars` seems a bit wasteful, in terms of possible throwing away already computed values, if a deeper environment variable is processed earlier (which is possible, since the iteration order of `os.environ` seems unpredictable). resolves pydantic#275
done |
hramezani
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a model defines a leaf as e.g. a string and the user or system sets an environment var with an additional
env_nested_delimiter + suffix,explode_env_varswas treating the string as adict(trying to add an item to it).This fix checks if the target is indeed a
dict.In that regard, the whole
explode_env_varsseems a bit wasteful, in terms of possible throwing away already computed values, if a deeper environment variable is processed earlier (which is possible, since the iteration order ofos.environseems unpredictable).resolves #275