Fix issue with recursive wrap function serializer schemas #530
Conversation
CodSpeed Performance ReportMerging #530 Summary
|
|
please review |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 94.80% 94.82% +0.01%
==========================================
Files 93 93
Lines 12304 12307 +3
Branches 26 26
==========================================
+ Hits 11665 11670 +5
+ Misses 631 629 -2
Partials 8 8
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -47,17 +47,23 @@ name = "_pydantic_core" | |||
| crate-type = ["cdylib", "rlib"] | |||
|
|
|||
| [features] | |||
| # must be disabled for cargo bench | |||
| extension-module = ["pyo3/extension-module"] | |||
There was a problem hiding this comment.
Looks like this can be safely removed (well, moved into the maturin config) thanks to the changes from this (recent) PR: PyO3/maturin#1479
Specifically, see this comment indicating that the intent was to make it so cargo test etc. can be used without flags: PyO3/maturin#1479 (comment)
|
|
||
| [profile.release] | ||
| lto = "fat" | ||
| codegen-units = 1 | ||
| strip = true | ||
|
|
||
| [dev-dependencies] | ||
| pyo3 = { version = "0.18.2", features = ["auto-initialize"] } |
There was a problem hiding this comment.
| pyo3 = { version = "0.18.2", features = ["auto-initialize"] } | |
| pyo3 = { version = "*", features = ["auto-initialize"] } |
That way we only have the version in one spot?
|
|
||
| [profile.release] | ||
| lto = "fat" | ||
| codegen-units = 1 | ||
| strip = true | ||
|
|
||
| [dev-dependencies] | ||
| pyo3 = { version = "0.18.2", features = ["auto-initialize"] } |
There was a problem hiding this comment.
got this idea from @davidhewitt in PyO3/maturin#1479 (comment)
This is necessary to resolve the issue @commonism reported in pydantic/pydantic#5387 while testing pydantic/pydantic#5385 (related to pydantic/pydantic#5383)