Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python3-dll-a dependency #1568

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

davidhewitt
Copy link
Contributor

Change Summary

python3-dll-a is a build dependency used internally by PyO3, we don't need to specify it here at all.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt enabled auto-merge (squash) December 2, 2024 11:15
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #1568 will not alter performance

Comparing dh/remove-python3-dll-a (8807fba) with main (298e4ea)

Summary

✅ 155 untouched benchmarks

@davidhewitt davidhewitt merged commit 167ffcf into main Dec 2, 2024
29 checks passed
@davidhewitt davidhewitt deleted the dh/remove-python3-dll-a branch December 2, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant