Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pandas tests to run on 3.12 #1097

Merged
merged 2 commits into from
Nov 29, 2023
Merged

bump pandas tests to run on 3.12 #1097

merged 2 commits into from
Nov 29, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Because it's now possible to run pandas on 3.12 tests, we should! Also this will be useful for me locally to debug the pandas failures in #1085

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #1097 (d3ead8b) into main (c7daf16) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         106      106           
  Lines       16359    16359           
  Branches       35       35           
=======================================
  Hits        14675    14675           
  Misses       1677     1677           
  Partials        7        7           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7daf16...d3ead8b. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 29, 2023

CodSpeed Performance Report

Merging #1097 will not alter performance

Comparing dh/bump-pandas (d3ead8b) with main (c7daf16)

Summary

✅ 140 untouched benchmarks

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! 🐼

@davidhewitt davidhewitt merged commit 5d64894 into main Nov 29, 2023
30 checks passed
@davidhewitt davidhewitt deleted the dh/bump-pandas branch November 29, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants