Parallelize tests using pytest-xdist #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 138 138
Lines 11044 11074 +30
Branches 1565 1569 +4
=========================================
+ Hits 11044 11074 +30 ☔ View full report in Codecov by Sentry. |
alexmojaki
reviewed
Feb 3, 2025
| @@ -61,6 +61,7 @@ def celery_worker(celery_app: Celery) -> Iterator[WorkController]: | |||
| yield worker | |||
|
|
|||
|
|
|||
| @pytest.mark.xdist_group(name='sequential') | |||
There was a problem hiding this comment.
I'm removing this one because I think this test is just flaky, I can't see evidence that xdist makes this fail more often.
alexmojaki
force-pushed
the
improve-tests-speed
branch
from
2bc8f76 to
232f66e
Compare
alexmojaki
reviewed
Feb 3, 2025
|
@sorasful awesome, thanks for the speedup! Is there a way to make it use |
Kludex
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I've noticed that the tests took a little while to run. So I've decided to see if we could parallelize them, I used
pytest-xdist.For very few tests (3), concurrency was a problem so I've decided to run them sequentially. I followed this issue to implement this :
pytest-dev/pytest-xdist#385
Now everything runs smoothly and quickly.