-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lossless float support #98
Conversation
CodSpeed Performance ReportMerging #98 will not alter performanceComparing Summary
|
let f = jiter | ||
.next_float() | ||
.map_err(|e| PyValueError::new_err(e.description(&jiter)))?; | ||
jiter | ||
.finish() | ||
.map_err(|e| PyValueError::new_err(e.description(&jiter)))?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite big brain 🧠. Is it worth considering a lower-level function to just try to parse the float as a number range and fail if it doesn't successfully consume the whole string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good as is.
fix #80.
Example usage: