Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup string parsing by copying serde a little #58

Merged
merged 7 commits into from
Jan 20, 2024

Conversation

samuelcolvin
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Jan 19, 2024

CodSpeed Performance Report

Merging #58 will improve performances by 49.96%

Comparing string-parsing-speedup (e5112ef) with main (0b21d4a)

Summary

⚡ 2 improvements
✅ 43 untouched benchmarks

🆕 6 new benchmarks

Benchmarks breakdown

Benchmark main string-parsing-speedup Change
x100_jiter_value 6.8 µs 5.5 µs +23.94%
🆕 sentence_serde_value N/A 24.4 µs N/A
🆕 sentence_jiter_iter N/A 18.3 µs N/A
x100_jiter_iter 4 µs 2.7 µs +49.96%
🆕 python_parse_x100_not_cached N/A 9.7 µs N/A
🆕 python_parse_x100 N/A 10 µs N/A
🆕 x100_serde_iter N/A 5.9 µs N/A
🆕 sentence_jiter_value N/A 20.4 µs N/A

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Merging #58 (e5112ef) into main (0b21d4a) will increase coverage by 0.22%.
The diff coverage is 98.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   95.12%   95.35%   +0.22%     
==========================================
  Files           8        8              
  Lines        1067     1097      +30     
==========================================
+ Hits         1015     1046      +31     
+ Misses         52       51       -1     
Files Coverage Δ
src/string_decoder.rs 94.63% <98.38%> (+2.19%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b21d4a...e5112ef. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 63e9881 into main Jan 20, 2024
10 checks passed
@samuelcolvin samuelcolvin deleted the string-parsing-speedup branch January 20, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants