-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from lexical-core to depend on lexical-parse-float directly #57
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 8 8
Lines 1097 1097
=======================================
Hits 1046 1046
Misses 51 51
Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #57 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll let @davidhewitt review and approve.
Sorry about the formatting, I forgot to run rustfmt after my changes. If I read the benchmark results correctly, this small change actually speeds things up measurably? That's interesting ... well, it's one fewer function call, so the code can probably be more optimized. |
|
LGTM, thanks! |
To summarise my opinion here: I think at some point we might want to remove the |
Closes #49.
Code changes are minimal - I have adjusted the
use
statement to import things under the same names as previously, and only one line of actual code needs to be changed - theparse_partial_with_options
function is fromlexical-core
, but it is a trivial one-line function, so it can just be replaced with calling the trait method on f64 directly.