Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on aarch64 linux wheels #175

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix crash on aarch64 linux wheels #175

merged 2 commits into from
Dec 2, 2024

Conversation

davidhewitt
Copy link
Collaborator

Investigating #174

Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #175 will not alter performance

Comparing dh/aarch64-ci-test (1cbf565) with main (4397293)

Summary

✅ 73 untouched benchmarks

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (4397293) to head (1cbf565).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   88.74%   88.75%   +0.01%     
==========================================
  Files          13       13              
  Lines        2203     2206       +3     
  Branches     2203     2206       +3     
==========================================
+ Hits         1955     1958       +3     
  Misses        153      153              
  Partials       95       95              
Files with missing lines Coverage Δ
crates/jiter/src/py_string_cache.rs 93.16% <100.00%> (+0.17%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4397293...1cbf565. Read the comment docs.

@davidhewitt davidhewitt changed the title ci: add further arch-specific testing fix crash on aarch64 linux wheels Dec 2, 2024
@davidhewitt
Copy link
Collaborator Author

@samuelcolvin looks like pystring_ascii_new is broken on aarch64 linux. That's... not a huge surprise, the underlying FFI there is extremely suspect, it's the worst bit of pyo3-ffi by far. I can't see anything obviously wrong but the bitflags stuff inside PyUnicode_DATA has always reeked of possible unsoundness. I'll follow up on PyO3 but for now disabling here.

I've disabled this on everything except x86_64 linux and arm macOS as the most well-tested platforms, to be safe.

@davidhewitt davidhewitt merged commit 866b667 into main Dec 2, 2024
58 checks passed
@davidhewitt davidhewitt deleted the dh/aarch64-ci-test branch December 2, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant