Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linux PGO wheel build #170

Merged
merged 3 commits into from
Nov 26, 2024
Merged

fix linux PGO wheel build #170

merged 3 commits into from
Nov 26, 2024

Conversation

davidhewitt
Copy link
Collaborator

Import of the same changes from pydantic/pydantic-core#1557 to here.

Might be nice to extract out into a re-usable action in a separate repo in the future. (Or to get this support into maturin-action).

Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #170 will not alter performance

Comparing dh/pgo-wheels (d4c685a) with main (72fc9ef)

Summary

✅ 73 untouched benchmarks

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (72fc9ef) to head (d4c685a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files          13       13           
  Lines        2203     2203           
  Branches     2203     2203           
=======================================
  Hits         1955     1955           
  Misses        153      153           
  Partials       95       95           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fc9ef...d4c685a. Read the comment docs.

@davidhewitt
Copy link
Collaborator Author

I will merge despite the CI failure; the break looks like it is probably a maturin issue on windows, I'll fix that separately (probably by disabling 3.13t builds on windows until next maturin release is done).

@davidhewitt davidhewitt merged commit 82df231 into main Nov 26, 2024
57 of 58 checks passed
@davidhewitt davidhewitt deleted the dh/pgo-wheels branch November 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant