Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests without num-bigint feature #169

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

cjwatson
Copy link
Contributor

cargo test --no-default-features and cargo test --no-default-features -F python failed due to various tests that required the num-bigint feature. Annotate these appropriately.

`cargo test --no-default-features` and `cargo test --no-default-features
-F python` failed due to various tests that required the `num-bigint`
feature.  Annotate these appropriately.
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (dbf0c52) to head (bd37d19).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files          13       13           
  Lines        2195     2195           
  Branches     2195     2195           
=======================================
  Hits         1952     1952           
  Misses        148      148           
  Partials       95       95           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf0c52...bd37d19. Read the comment docs.

---- 🚨 Try these New Features:

Copy link

codspeed-hq bot commented Nov 24, 2024

CodSpeed Performance Report

Merging #169 will improve performances by 12.03%

Comparing cjwatson:num-bigint-tests (bd37d19) with main (dbf0c52)

Summary

⚡ 1 improvements
✅ 72 untouched benchmarks

Benchmarks breakdown

Benchmark main cjwatson:num-bigint-tests Change
unicode_jiter_iter 8.6 µs 7.7 µs +12.03%

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@davidhewitt davidhewitt merged commit 9ad1d5a into pydantic:main Nov 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants